-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Fair Share Tax #904
Add a Fair Share Tax #904
Conversation
…. Renames BuffettRule function to FairShareTax.
…. Renames BuffettRule function to FairShareTax.
…. Renames BuffettRule function to FairShareTax.
Current coverage is 98.12% (diff: 100%)@@ master #904 diff @@
==========================================
Files 13 13
Lines 1813 1814 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1779 1780 +1
Misses 34 34
Partials 0 0
|
@andersonfrailey said:
Thanks for the clarification of the function and parameters naming. If this pull request #904 is meant to replace pull request #890, then you should close (without merging) pull request #890 so as to eliminate any possible confusion. |
@andersonfrailey said:
You need to tell us the values of the three
|
@martinholmer the only parameter changed was _FST_tentRate. It is now 0.3. |
@MattHJensen said in issue #862:
@andersonfrailey, Are we just abstracting from the after-only-certain-credits aspect of the reform. It looks as if pull request #904 includes all the credits in the income tax liability. Is that what you and Matt agreed to do? If so, fine. I'm just trying to clarify things in my own mind. Also, Matt's description quoted above is different than the logic you have in pull request #904 with respect to "the employee portion of payroll taxes." First, the And second, there is an ambiguity about what exactly is the "employee share" of the Self-Employment Tax (payroll taxes collected on self-employment income). Does the Fair Share Tax reform regard half or all of the Self-Employment Tax as being the "employee share"? The self-employed worker actually does pay all of the Self-Employment Tax. Remember that the whole Self-Employment Tax is included in the And a couple of questions about the |
@andersonfrailey said about the Fair Share Tax reform he simulated:
Thanks for the clarification. So, my other (more recent) questions about pull request #904 are still relevant. |
Yes, we are abstracting from that aspect of the reform.
Thanks for pointing this out. For the next push I plan on using half of As for the employee share of the Self-Employment Tax, the proposal does not specify whether half or all of the Self-Employment Tax will be used when calculating FST. I'm inclined to use half of the Self-Employment Tax, though I have yet to find evidence that the Clinton team or other models do.
I have changed the default for the parameter to be indexed for inflation. I will also add an index for filing unit type. |
@andersonfrailey said:
Yes, this is correct, but incomplete as you realize when you say:
Half sounds reasonable. Any contrary thoughts from @MattHJensen or Dan @feenberg? @andersonfrailey also said:
OK, we'll look forward to the next version of pull request #904. Remember that when the FST_thd parameter is inflation indexed it will be greater than one million in 2017, which I'm assuming is the first year of the FST reform. So you will have to do two things: set the FST_trt to 0.30 and set the FST_thd to 1000000 beginning in 2017. When you do that with the above logic corrections, can you present again (like you did in #890) the aggregate revenue effects from Tax-Calculator and compare those estimates with other estimates. |
@andersonfrailey, I forgot to mention that there is yet another subitem in the |
The latest push uses the variables added in #909 to compute the employee share of payroll taxes, assuming half of the self-employment tax is used for the calculation. It moves the FairShareTax function above the BenefitSurtax function to avoid any conflict with the _iitax variable. It renames My revenue estimates after setting
With the new variables for payroll taxes the TC estimates have moved slightly closer to the others, but are still pretty far out there. |
…thd for inflation and marital status.
@andersonfrailey, Pull request #904 is starting to look good. After discussing the The suggested set of
Does this make sense? If not, let's discuss this further. If so, can you make these changes in Also, can you post here the Fair Share Tax reform dictionary that you are using to specify the reform? Thanks for all the work on this. This is going to be an important addition to Tax-Calculator. |
Could you clarify a little more what the functionality of In the Clinton proposal, for example,
And here is the reform dictionary I've been using:
|
@andersonfrailey asked:
Yes, this is exactly the way I'm thinking about these three FST parameters. And just to be extra clear, if Does all that make sense? |
@andersonfrailey, I don't understand why there are so many changed files (56) in pull request #904. Shouln't there be just a handful? Here's how to fix this problem: (1) checkout master, (2) make sure your local master is up-to-date with the GitHub master, (3) checkout your FairShareTax branch, (4) merge master into FairShareTax branch ( This process has many steps, but each one is fairly simple. If you have any questions about this, ask @MattHJensen or @Amy-Xu for advice. |
The latest push implements the I've set the default values for I'm still getting revenue estimates that are abnormally large compared to others:
I used the new PUF as well as this reform dictionary:
|
@andersonfrailey, Pull request #904 looks much cleaner now; thanks for getting it in sync with the latest on the master branch. I guess the major outstanding question is why does the reform raise so much more than other models are estimating. But before focusing on that, I have one question about the calculation of the Fair Share Tax in this code:
Why is the |
@martinholmer said:
Yes you're correct. I missed that in the C1040 function. After correcting for that the new revenue estimates I'm getting are:
|
@andersonfrailey said:
So, fixing that makes the estimates even further away from those generated by other models. Right? Your earlier summary of other estimates was:
Does anybody have any ideas about why the other models generate such different estimates? |
@andersonfrailey, I can confirm on my own computer your $30.01 billion revenue increase for 2017. |
Here's one idea: Both TPC and Treasury may be stacking this proposal after other reforms, in particular a limitation on itemized deductions. Neither explicitly state the stacking order, but the FST does appear below the itemized deduction limitations in their tables. The JCT estimate is not so easy to explain away since the FST appears to be analyzed alone. |
Shall we merge this (pull request #904) now and possibly investigate the differences between Tax-Calculator and the JCT model? |
@martinholmer said:
Correct. @MattHJensen said:
I'll run the calculator again this time with a few of the other tax proposals mentioned in in the TPC and Treasury proposals and see what if any affects they have on the taxcalc estimates. |
@andersonfrailey said:
That would be good. Meanwhile, I'm going to merge this pull request #904 into the master branch so that pending merges don't introduce "conflicts with the base branch." Thanks for all the work on this @andersonfrailey. We can all continue to investigate cross-model differences on the master branch. |
Tax Foundation has a very similar estimate to TC. http://taxfoundation.org/sites/default/files/docs/TaxFoundation-FF496.pdf |
This is the same as PR #890, the only difference is it uses a new branch that has been updated to match the master branch. It still addresses issue #862.
I've changed the name of the BuffettRule function to FairShareTax and some of the code to match the codebase.
I'm still working on making our output more on par with the other revenue estimates. This is what I currently have (billions of dollars):