Revise Calculator.calc_all() so it does only static analysis #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 98.12% (diff: 100%)@@ master #857 diff @@
==========================================
Files 13 13
Lines 1809 1811 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1775 1777 +2
Misses 34 34
Partials 0 0
|
martinholmer
changed the title
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the faulty 'Calculator.call_all()' logic introduced a day ago in pull request #849. Now the
calc_all()method does what it has always done: static analysis only. The idiom for conducting dynamic analysis with behavioral responses is illustrated in the revisedtaxcalc/comparion/reform_results.pyandtaxcalc/taxbrain/behavior.pyscripts and in the revisedmultiyear_diagnostic_table()utility function.@MattHJensen @feenberg @codykallen @Amy-Xu @GoFroggyRun