Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new test to test_functions.py as promised in PR#832 #833

Merged
merged 34 commits into from
Jul 23, 2016
Merged

Add new test to test_functions.py as promised in PR#832 #833

merged 34 commits into from
Jul 23, 2016

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Jul 20, 2016

This pull request #833 contains all of the changes in pull request #832 and also adds a new test to the test_functions.py file (as promised in pull request #832). The usefulness of this test is described in the conversation about pull request #832.

@MattHJensen @feenberg @talumbau @Amy-Xu @GoFroggyRun @zrisher

@codecov-io
Copy link

codecov-io commented Jul 20, 2016

Current coverage is 98.08%

Merging #833 into master will decrease coverage by <.01%

@@             master       #833   diff @@
==========================================
  Files            13         13          
  Lines          1777       1774     -3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1743       1740     -3   
  Misses           34         34          
  Partials          0          0          

Powered by Codecov. Last updated by 63fb101...e57ae1d

@zrisher
Copy link
Contributor

zrisher commented Jul 22, 2016

@martinholmer A lot of very positive changes in here, nice work!

@martinholmer martinholmer merged commit 7317f2c into PSLmodels:master Jul 23, 2016
@martinholmer martinholmer deleted the add-functions-test2 branch July 23, 2016 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants