Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] itemized deduction surtax and itemized deduction haircut consistency #490

Closed
wants to merge 4 commits into from
Closed

[WIP] itemized deduction surtax and itemized deduction haircut consistency #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90a87ce
add test for ID_HC and ID_surtax consistency
MattHJensen Nov 29, 2015
fa48bf0
allow for id_hc and id_surtax to be almost_equal
MattHJensen Nov 29, 2015
514e7f4
add surtax to _combined as well as _iitax
MattHJensen Nov 29, 2015
982e350
ID_casualty_HC -> ID_Casualty_HC typo fix in surtax function
MattHJensen Nov 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion taxcalc/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1706,7 +1706,7 @@ def BenefitSurtax(calc):
int(nobenefits_calc.policy.ID_BenefitSurtax_Switch[1])
nobenefits_calc.policy.ID_RealEstate_HC = \
int(nobenefits_calc.policy.ID_BenefitSurtax_Switch[2])
nobenefits_calc.policy.ID_casualty_HC = \
nobenefits_calc.policy.ID_Casualty_HC = \
int(nobenefits_calc.policy.ID_BenefitSurtax_Switch[3])
nobenefits_calc.policy.ID_Miscellaneous_HC = \
int(nobenefits_calc.policy.ID_BenefitSurtax_Switch[4])
Expand All @@ -1730,3 +1730,4 @@ def BenefitSurtax(calc):
0) * calc.policy.ID_BenefitSurtax_trt

calc.records._iitax += calc.records._surtax
calc.records._combined += calc.records._surtax
33 changes: 32 additions & 1 deletion taxcalc/tests/test_calculate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
CUR_PATH = os.path.abspath(os.path.dirname(__file__))
sys.path.append(os.path.join(CUR_PATH, "../../"))
import numpy as np
from numpy.testing import assert_array_equal
from numpy.testing import assert_array_equal, assert_array_almost_equal
import pandas as pd
import tempfile
import pytest
Expand Down Expand Up @@ -298,6 +298,37 @@ def test_calculate_mtr():
assert np.array_equal(mtr_FICA, mtr_IIT) == False


def test_ID_hc_vs_surtax():
policy1 = Policy()
puf1 = Records(TAX_DTA, weights=WEIGHTS, start_year=2009)
calc1 = Calculator(policy=policy1, records=puf1)

policy2 = Policy()
puf2 = Records(TAX_DTA, weights=WEIGHTS, start_year=2009)
calc2 = Calculator(policy=policy2, records=puf2)

reform1 = {2013: {'_ID_Medical_HC': [1],
'_ID_StateLocalTax_HC': [1],
'_ID_RealEstate_HC': [1],
'_ID_Casualty_HC': [1],
'_ID_Miscellaneous_HC': [1],
'_ID_InterestPaid_HC': [1],
'_ID_Charity_HC': [1]
}
}
reform2 = {2013: {'_ID_BenefitSurtax_crt': [0]
}
}

policy1.implement_reform(reform1)
policy2.implement_reform(reform2)

calc1.calc_all()
calc2.calc_all()

assert_array_almost_equal(calc1.records._combined, calc2.records._combined, decimal=2)


def test_Calculator_create_difference_table():
# create current-law Policy object and use to create Calculator calc1
policy1 = Policy()
Expand Down