Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix education tax credit phase-out parameters #2790

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

martinholmer
Copy link
Collaborator

This pull request fixes two errors made in PR #2633:

  • the 2022 value of ETC_pe_Single was incorrect (being set to $80K instead of $90K), and
  • the value of the indexed attribute was not changed to false for the two ETC_pe_* parameters.

For details, see this section of the Internal Revenue Code and the fact that the values of the ETC_pe_* parameters are not mentioned in the IRS Rev. Proc. 2022-38 document containing 2023 values of inflation-indexed parameters.

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (728d81a) to head (923b4f2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2790   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2613     2613           
=======================================
  Hits         2598     2598           
  Misses         15       15           
Flag Coverage Δ
unittests 99.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martinholmer martinholmer merged commit b3efee0 into PSLmodels:master Aug 3, 2024
11 checks passed
@martinholmer martinholmer deleted the fix-etc-phaseout branch August 3, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant