Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qualified business income calculation #2785

Merged
merged 5 commits into from
Jul 28, 2024

Conversation

martinholmer
Copy link
Collaborator

The 4.2.0 version of Tax-Calculator does not calculate qualified business income (QBI) correctly when the business income is from self-employment (that is, reported on Schedule C). The reason for the miscalculation is that the above-the-line deduction for the self-employment (SECA) tax on Schedule C income is not being subtracted from Schedule C gross income to get "Net QBI". Here are two IRS forms as generated by 2022 Turbo Tax for a tax unit in which the head has $200,000 in Schedule C income and qualified business income of $188,208 with the difference being the $11,792 above-the-line deduction for the self-employment (SECA) tax.

First the form that computes the self-employment tax:

Screenshot 2024-07-28 at 1 39 10 PM

.

Then the QBID (Form 8995) summary:

Screenshot 2024-07-28 at 1 44 20 PM

@martinholmer martinholmer marked this pull request as draft July 28, 2024 18:07
@martinholmer martinholmer marked this pull request as ready for review July 28, 2024 18:59
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (0b775e5) to head (5621d50).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2785   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2613     2613           
=======================================
  Hits         2598     2598           
  Misses         15       15           
Flag Coverage Δ
unittests 99.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martinholmer martinholmer requested a review from jdebacker July 28, 2024 19:29
@jdebacker
Copy link
Member

@martinholmer Thanks for finding and fixing this bug. Merging changes.

@jdebacker jdebacker merged commit fb0c3c0 into PSLmodels:master Jul 28, 2024
11 checks passed
@martinholmer martinholmer deleted the fix-qbi-calc branch July 28, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants