Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix four 2020 PT_rt? parameter values #2783

Merged
merged 3 commits into from
Jul 27, 2024

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Jul 26, 2024

Fixes #2782 by correcting mistakes made in PR #2633.

@martinholmer martinholmer requested a review from jdebacker July 26, 2024 19:41
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (b41af53) to head (6f9d8f4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2783   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2613     2613           
=======================================
  Hits         2598     2598           
  Misses         15       15           
Flag Coverage Δ
unittests 99.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jdebacker
Copy link
Member

@martinholmer Thanks for noticing and fixing these parameter value errors. I'm sorry I missed them in my review of the original PR.

The changes here are great. I ran the validation tests as well and this resolves some differences between Tax-Calculator and TAXSIM-35 for the "c" file for 2020.

@jdebacker jdebacker merged commit 0b775e5 into PSLmodels:master Jul 27, 2024
11 checks passed
@martinholmer
Copy link
Collaborator Author

@jdebacker said in PR #2783:

The changes here are great. I ran the validation tests as well and this resolves some differences between Tax-Calculator and TAXSIM-35 for the "c" file for 2020.

Great! Progress all around.

I'm wondering why the 2020 analysis of the "c" file diffs between Tax-Calculator and TAXSIM-35 didn't reveal this bug. Any thoughts on that?

@martinholmer martinholmer deleted the fix-2020-PT_rt-params branch July 27, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Four incorrect PT_rt? policy parameter values for 2020
2 participants