4.0.0 release #2753

bodiyang · 2024-05-30T14:27:41Z

This PR prepares Tax-Calc 4.0.0 new version release.

please check release.md file for the new features of the model.

…ers.

… 100.

Update to CDCC_prt

Divide CDCC parameters by 100

Update CDCC rates in reform to be on new scale

Update fix conflict branch

Update v4 branch with latest from master

add Employer side payroll parameters

Sync v4 branch with master

Update v4 development branch with latest from master

V4 development

Merge master into V4 development

Sync `v4_development` branch to `master`

V4 development

martinholmer · 2024-05-30T16:34:23Z

@bodiyang, I don't understand why you have submitted PR #2753 when tests are failing.
Please, revise you code so that ALL tests pass on you local computer. Then submit the PR.

jdebacker · 2024-05-30T17:10:57Z

@martinholmer, please see PR #2753 to better understand what is going on.

@bodiyang Can you make this a draft PR until #2573 is merged?

martinholmer · 2024-05-30T17:46:53Z

@jdebacker said:

PR #2753 to better understand what is going on.

There was absolutely no explanation of "what is going on" in that original PR.

jdebacker · 2024-06-03T17:29:09Z

docs/about/releases.md

+**This is a major release with changes that make Tax-Calculator incompatible with earlier releases.**
+
+**API Changes**
+- Reframewrok of the payroll tax policy parameters: Payroll tax parameters are split into the employer side and employee side ~ `FICA_mc_trt`, `FICA_ss_trt` are replaced by `FICA_mc_trt_employer`, `FICA_mc_trt_employee`, `FICA_ss_trt_employer` and `FICA_ss_trt_employee`. [[#2669](https://github.com/PSLmodels/Tax-Calculator/pull/2669) by Bodi Yang]


"Reframework" spelled wrong -- and perhaps use "Apply a new framework for the payroll..."

merge

jdebacker · 2024-06-04T14:38:38Z

@bodiyang This branch appears to be just a few changes from master (version numbers, release notes). Can you merge the latest v4_development branch into your 4.0.0-release branch?

V4 development

bodiyang · 2024-06-04T15:39:41Z

@bodiyang This branch appears to be just a few changes from master (version numbers, release notes). Can you merge the latest v4_development branch into your 4.0.0-release branch?

have merge the change from v4_development into 4.0.0-release

codecov · 2024-06-04T16:00:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (e0234b6) to head (cb7b95a).
Report is 16 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2753   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2605     2605           
=======================================
  Hits         2590     2590           
  Misses         15       15

Flag	Coverage Δ
unittests	`99.42% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
taxcalc/__init__.py	`100.00% <100.00%> (ø)`
taxcalc/calculator.py	`100.00% <ø> (ø)`
taxcalc/parameters.py	`100.00% <ø> (ø)`

jdebacker · 2024-06-04T20:23:26Z

docs/about/releases.md

@@ -3,6 +3,20 @@ Release history
 Go [here](https://github.com/PSLmodels/Tax-Calculator/pulls?q=is%3Apr+is%3Aclosed)
 for a complete commit history.

+2024-06-01 Release 4.0.0
+------------------------
+(last merged pull request is


Should be #2752

docs/about/releases.md

…to 4.0.0-release

bodiyang · 2024-06-05T17:55:57Z

@jdebacker have update the documentation. current testing failure is from the codecov ~ probably we can have a rerun of the tests

duncanhobbs and others added 30 commits September 30, 2021 14:22

Divide CDCC_crt and CDCC_frt parameters by 100 to match other paramet…

29f91fc

…ers.

Update documentation for CDCC_crt and CDCC_frt to reflect division by…

25c5cfe

… 100.

Update test_reforms.py with adjusted parameter values.

473ae2a

Correct precision of CDCC_frt.

fac5f21

make CDCC_prt a rate

7fbd861

update F2441 docstring

b4b1749

Merge pull request #1 from jdebacker/pr-2628

1cf3c04

Update to CDCC_prt

Merge pull request PSLmodels#2628 from duncanhobbs/divide-by-100

cd37b7f

Divide CDCC parameters by 100

update documentation of policy parameters

3cf3a21

update functions

73ee270

update reform, tests files

8c9de96

update parameter in policy law file

d25902f

update testing reform file

0969fc8

solve payroll testing problem

8255631

Merge branch 'v4_development' into its_merge_conflict_fix

f323e85

change CDCC rate scale

dc5f6b6

Merge branch 'v4_development' into pr-2670

cdc449d

Merge pull request PSLmodels#2671 from jdebacker/pr-2670

c37e14e

Update CDCC rates in reform to be on new scale

Merge pull request PSLmodels#2672 from PSLmodels/v4_development

dce49ac

Update fix conflict branch

Merge pull request PSLmodels#2670 from PSLmodels/its_merge_conflict_fix

0444a60

Update v4 branch with latest from master

Merge pull request PSLmodels#2669 from bodiyang/employer-payroll

c6420c1

add Employer side payroll parameters

Merge pull request PSLmodels#2680 from PSLmodels/master

01ebe83

Sync v4 branch with master

Merge pull request PSLmodels#2693 from PSLmodels/master

bc20f78

Update v4 development branch with latest from master

Merge pull request #34 from PSLmodels/v4_development

0495b94

V4 development

Merge branch 'v4_development' into master_v4_conflicts

829892d

Merge pull request PSLmodels#2742 from PSLmodels/master_v4_conflicts

877145a

Merge master into V4 development

Merge pull request PSLmodels#2749 from PSLmodels/master

9560083

Sync `v4_development` branch to `master`

Merge pull request #43 from PSLmodels/v4_development

f313bfe

V4 development

release doc

ebf0cfa

update version

8ab58fc

martinholmer closed this May 30, 2024

jdebacker reopened this May 30, 2024

bodiyang marked this pull request as draft May 30, 2024 19:02

jdebacker reviewed Jun 3, 2024

View reviewed changes

Bodi Yang and others added 2 commits June 3, 2024 14:39

change documentation

ee589b9

Merge pull request #45 from PSLmodels/master

802e20e

merge

bodiyang added 2 commits June 4, 2024 11:37

Merge branch '4.0.0-release' into v4_development

dcdf068

Merge pull request #46 from bodiyang/v4_development

2794aa4

V4 development

bodiyang marked this pull request as ready for review June 4, 2024 15:40

jdebacker reviewed Jun 4, 2024

View reviewed changes

docs/about/releases.md Outdated Show resolved Hide resolved

Bodi Yang added 3 commits June 5, 2024 09:05

releases.md

96e9f16

Merge branch '4.0.0-release' of github.com:bodiyang/Tax-Calculator in…

1a6b09c

…to 4.0.0-release

update release file

cb7b95a

martinholmer closed this Jun 5, 2024

martinholmer reopened this Jun 5, 2024

martinholmer merged commit 5e40363 into PSLmodels:master Jun 5, 2024
10 of 16 checks passed

This was referenced Jun 6, 2024

Introduce tax offset (employer side payroll) into Tax-Calc #2665

Closed

split payroll tax functions #2692

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

4.0.0 release #2753

4.0.0 release #2753

bodiyang commented May 30, 2024 •

edited

Loading

martinholmer commented May 30, 2024

jdebacker commented May 30, 2024

martinholmer commented May 30, 2024

jdebacker Jun 3, 2024

jdebacker commented Jun 4, 2024

bodiyang commented Jun 4, 2024

codecov bot commented Jun 4, 2024 •

edited

Loading

jdebacker Jun 4, 2024

bodiyang commented Jun 5, 2024

4.0.0 release #2753

4.0.0 release #2753

Conversation

bodiyang commented May 30, 2024 • edited Loading

martinholmer commented May 30, 2024

jdebacker commented May 30, 2024

martinholmer commented May 30, 2024

jdebacker Jun 3, 2024

Choose a reason for hiding this comment

jdebacker commented Jun 4, 2024

bodiyang commented Jun 4, 2024

codecov bot commented Jun 4, 2024 • edited Loading

Codecov Report

jdebacker Jun 4, 2024

Choose a reason for hiding this comment

bodiyang commented Jun 5, 2024

bodiyang commented May 30, 2024 •

edited

Loading

codecov bot commented Jun 4, 2024 •

edited

Loading