prepares 3.4.0

[bodiyang]

No description provided.

[codecov]

Codecov Report

Merging #2681 (952471d) into master (c5a6271) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 952471d differs from pull request most recent head edfac77. Consider uploading reports for the commit edfac77 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2681   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          14       14           
  Lines        2609     2609           
=======================================
  Hits         2571     2571           
  Misses         38       38           

Flag	Coverage Δ
unittests	98.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
taxcalc/__init__.py	100.00% <100.00%> (ø)

[jdebacker]

@bodiyang Let two comments in this review. If you could make those changes and sync this branch to the master branch, that would be helpful.

BTW, in the future you should use a development branch, not your master branch, for these changes.

[bodiyang]

@jdebacker thanks Jason!

[jdebacker]

Date change here.

[jdebacker]

@bodiyang One more date change. And then please resolve conflicts from test_stats_benchmark.csv and I will merge. Thanks!

[feenberg]

I wish you would use the latest version - taxsim35. It will accept taxsim27 input files, so the change should not be troublesome. I can send a linux, osx or windows binary. Daniel Feenberg 617-682-6204

…

On Fri, 5 May 2023, Jason DeBacker wrote: @jdebacker commented on this pull request. ____________________________________________________________________________ In docs/index.md: > @@ -51,7 +51,7 @@ The cross-model validation work with NBER's TAXSIM-27 mo del is described ## Latest release -{doc}`3.3.0 (2022-12-16) <about/releases>` +{doc}`3.4.0 (2023-05-16) <about/releases>` Date change here. ? Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to thisthread.[AB55AVNT6XY2ESXLPVEXUVDXEVQJ5A5CNFSM6AAAAAAXUN7NSWWGG33NNVSW45C7OR4 XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSULXBE6.gif] Message ID: ***@***.***>

[jdebacker]

@feenberg comments:

I wish you would use the latest version - taxsim35. It will accept
taxsim27 input files, so the change should not be troublesome.

With the recent merge of PR #2619, we do have validation files to work with taxsim35. For now, we've left in the taxsim27 validation files as well, but will likely remove those in a future release.

[jdebacker]

@bodiyang Thanks for this PR. Merging.