Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete and correct work for updates to inflation indexed parameters #2652

Merged
merged 16 commits into from
May 11, 2022

Conversation

bodiyang
Copy link
Contributor

No description provided.

@jdebacker jdebacker changed the title update for Martin's open issues #2647, 2649, and 2651 Complete and correct work for updates to inflation indexed parameters Mar 22, 2022
@jdebacker
Copy link
Member

This PR responds to Issues #2647, #2649, and #2651

@jdebacker
Copy link
Member

jdebacker commented Mar 22, 2022

  • ALD_BusinessLosses_c parameter values for 2020-2022
  • PT_qbid_taxinc_thd parameter values for 2020 and 2021
  • Check order of years in current_law_policy.json
  • Fix headhh CG_brk2 value, it should be 469, 050
  • Correct values for EITC_ps in years 2020-2022
  • Correct values for EITC_ps_MarriedJ in years 2020-2022

@bodiyang
Copy link
Contributor Author

bodiyang commented Mar 28, 2022

  • ALD_BusinessLosses_c parameter values for 2020-2022
  • PT_qbid_taxinc_thd parameter values for 2020 and 2021
  • Check order of years in current_law_policy.json
  • Fix headhh CG_brk2 value, it should be 469, 050
  • Correct values for EITC_ps in years 2020-2022
  • Correct values for EITC_ps_MarriedJ in years 2020-2022

Have checked the EITC_ps_MarriedJ in years 2020-2022, the value should be correct; also the years should be in order in current_law_policy.json

@jdebacker
Copy link
Member

@bodiyang please see my PR to your branch where I create a json file to handle indexed parameter rounding for the round trip reform.

@jdebacker
Copy link
Member

@bodiyang Let me know if there are any issues with my PR to your branch. If you think it's ok, let's merge it. Thanks.

Include inflation rounding json file
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #2652 (451babf) into master (d058cb2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2652   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          14       14           
  Lines        2609     2609           
=======================================
  Hits         2571     2571           
  Misses         38       38           
Flag Coverage Δ
unittests 98.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jdebacker
Copy link
Member

@bodiyang I remaining incorrect parameter values for EITC_ps_MarriedJ and just opened a PR to your branch with that fix.

@MattHJensen There's a lot here and I don't want to miss something again. Can you put another set of eyes on this PR and let me know if there are still years out of order or if we failed to correct anything noted in Issues #2647, #2649, #2651 and now Issue #2655?

@jdebacker jdebacker requested a review from MattHJensen April 19, 2022 01:18
@jdebacker
Copy link
Member

Thanks for your work on this @bodiyang!

Merging despite a failure when testing on Windows with Python 3.7. Error looks like an idiosyncratic issue with connecting to Codecov.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants