-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready] Remove Python 3.6 from tests in GH Actions #2584
Conversation
@chusloj Thanks for taking care of this! Do you want to try to see if we can get code coverage working now (uncommenting the upload report lines)? Also, we might want to add |
Codecov Report
@@ Coverage Diff @@
## master #2584 +/- ##
==========================================
- Coverage 99.92% 98.46% -1.46%
==========================================
Files 13 14 +1
Lines 2591 2611 +20
==========================================
- Hits 2589 2571 -18
- Misses 2 40 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Code coverage is back! Thanks @chusloj! |
@jdebacker Code coverage is back, but @MattHJensen In the environment file, |
@chusloj could you help me understand that 1.45% reported reduction in code coverage? |
@MattHJensen Looks like coverage now is compared to coverage from the last PR merged before codecov was shut off, which looks to be #2512. Regarding this patch, codecov says that this Tax-Calculator/taxcalc/data.py Line 104 in 46dcd32
|
This PR removes Python 3.6 from the GH action's test suite. Addresses #2582.
cc @MattHJensen