-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix related params #2532
Fix related params #2532
Conversation
- Defers validation on related parameters until the transaction is complete
I took a look at a simple bench mark that adjust a parameter over multiple years |
I'll fix the ParamTools warning in a follow up PR. I started working on this here while developing the new API in ParamTools. This may improve the performance a slight bit, too. |
- Mostly reformats docs to be rendered by jupyter books - Clarifies some grammer/long sentences - Removes inherited ParamTools methods from the docs and replaces them with a link to the ParamTools docs
Latest commit d4e706f cleans up some of the parameters documentation:
@MattHJensen there are a lot of changes in this commit, most of them are just formatting. I did update the docstrings in a couple places and I'll drop some comments to let you know where. |
Thanks a lot, @hdoupe. This looks good to me. Merging. |
Resolves #2531 using transaction method added in PSLmodels/ParamTools#123.
TODO: