Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cases file to replace citations BibTex file #2494

Merged
merged 4 commits into from
Nov 4, 2020

Conversation

chusloj
Copy link
Contributor

@chusloj chusloj commented Sep 23, 2020

This PR introduces use_cases.md as a single, human-readable bibliography to replace the use of citations.bib and the need for zcitations.md in the TOC within the docs from #2473.

@MattHJensen

@chusloj
Copy link
Contributor Author

chusloj commented Sep 23, 2020

A new preview file is now available in #2480.

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #2494 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2494   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          13       13           
  Lines        2582     2591    +9     
=======================================
+ Hits         2580     2589    +9     
  Misses          2        2           
Impacted Files Coverage Δ
taxcalc/calculator.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc7232...3a6614d. Read the comment docs.

@MattHJensen
Copy link
Contributor

@chusloj, thanks a lot for this PR and apologies for my delayed response.

Could you update for more recent use cases, close other related but now outdated PRs (I believe #2480, #2473), and then ping me again to merge this?

Also, the filename is good, but it would likely be helpful to title the top of the file "Recorded use cases" Rather than just "Use cases".

@chusloj
Copy link
Contributor Author

chusloj commented Nov 2, 2020

  • Update for most recent use cases
  • Change filename to "Recorded use cases"
  • Close outdated PRs

@chusloj
Copy link
Contributor Author

chusloj commented Nov 2, 2020

These are the new citations to be added to use_cases.md. Updates range from March of this year up to now.


@chusloj
Copy link
Contributor Author

chusloj commented Nov 3, 2020

@MattHJensen The new citations you listed have been added to the use cases.

@MattHJensen
Copy link
Contributor

Thanks @chusloj. Very much appreciate your taking the initiative on this and working through a few ideas w/ me on how it would be implemented and updated. The new file ought to be of great help to Tax-Calculator supporters and prospective users. Merging.

@MattHJensen MattHJensen merged commit 316a82f into PSLmodels:master Nov 4, 2020
@chusloj chusloj deleted the citations_final branch November 4, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants