-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update data files to reflect July 2020 changes in CBO economic projections and create new ppp.py #2462
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2462 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 13 13
Lines 2582 2582
=======================================
Hits 2580 2580
Misses 2 2 Continue to review full report at Codecov.
|
Looks good @Peter-Metz. I'll get the updates into ParamTools tomorrow. |
@Peter-Metz, thanks a lot for this PR and working through the ppp.py update for ParamTools (Thanks for your help @hdoupe!). My sense -- but I may be misunderstanding -- is that separating out the ppp.py changes from the data update into two different PRs would allow us to better verify that the ppp.py changes are working as expected. I.e., we should see no test difference in the ppp.py PR. Does that makes sense to you? |
@MattHJensen I made sure of this locally (and actually uncovered a tiny error in pcl -- I'm still happy to open a separate PR. Let me know your preference. |
Thanks @Peter-Metz, since you are willing to separate the PRs, let's do that for posterity. |
@MattHJensen sure thing, see #2466 |
@Peter-Metz, this is looking good, but the PR now has merge conflicts. Could you drop the (new) WIP tag when they are resolved? Also, could you help me understand why there are changes to the cpscsv output in this PR? |
This is due to changes in |
@MattHJensen conflicts should be resolved |
Ok, that's great. I am merging. Thanks again for this PR @Peter-Metz and thanks for the data update in TaxData @chusloj and review of the TaxData update @andersonfrailey! |
Two components to this PR:
Creates a newppp.py
file. Tax-Calculator's adoption of Paramtools for parameter processing necessitated a newppp.py
script due to changes in the way parameters are defined. The functionality is similar. Moving forward,ppp.py
will need to be run whenever inflation rates are updated ingrowfactors.csv
. Thanks to @hdoupe for helping sort out some Paramtools issues.Edit: the changes to
ppp.py
are now handled in #2466cc @MattHJensen