-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't index SALT cap (ID_AllTaxes_c) #2388
Conversation
This is failing the TCJA round trip test:
Seems like TCJA is stuck with the indexed values, but I can't find how to change that (or in general how to change whether a value is indexed in a reform). cc @MattHJensen in case you'd started working on this |
@MaxGhenis, these lines need to be all be the same as this line. The ceiling expires in 2026, so we have to specify all values out to 2026 in order to specify the 9e+99 in that year. The I'm hoping to get the bug release out today or tomorrow, so if you don't think you'll have a chance to look at this again until after that, please let me know. Thanks a lot for tackling this! |
Codecov Report
@@ Coverage Diff @@
## master #2388 +/- ##
======================================
Coverage 100% 100%
======================================
Files 13 13
Lines 2749 2749
======================================
Hits 2749 2749 Continue to review full report at Codecov.
|
Thanks @MattHJensen, all set now. |
Odd, there was a conda error after updating
Per conda/conda#3935 (comment) (3 years old) the recommended fix is to use
Anyone hit this before or know how to do it for Travis? If not I can ask on that issue. |
…. done Solving environment: ...working... failed with repodata from current_repodata.json, will retry with next repodata source. to setup_conda_environment.cmd
Thanks a lot, @MaxGhenis. This looks good to me. Good for me to merge from your end? |
Yep! |
Sorry I wanted to amend a previously messed-up commit message, didn't expect it to re-trigger tests. No code has changed so tests should succeed soon. |
OK all set for real now! |
Thanks, Max. Merging. |
Fixes #2387