-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Records class logic #2337
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2337 +/- ##
======================================
Coverage 100% 100%
======================================
Files 12 13 +1
Lines 2713 2741 +28
======================================
+ Hits 2713 2741 +28
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request separates the logic in the old Records class into two parts: the generic code involved in handling data observations that are aged each year and code that is specific to the Tax-Calculator model. The generic code is now in a new abstract base class called Data with code in the
taxcalc/data.py
file and tests in thetaxcalc/tests/test_data.py
file. The Tax-Calculator-specific code is in the revised Records class, which is now derived from the Data class (in the same way as the Policy class is derived from the Parameters class).There should be no effect on models that use the high-level Records capabilities of Tax-Calculator because those high-level capabilities have not changed.