Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistaken change in 2017 _EITC_ps_MarriedJ parameter value made in PR 2212 #2240

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Fix mistaken change in 2017 _EITC_ps_MarriedJ parameter value made in PR 2212 #2240

merged 1 commit into from
Feb 22, 2019

Conversation

martinholmer
Copy link
Collaborator

This pull request undoes a mistaken change in PR #2212 of the 2017 value of the _EITC_ps_MarriedJ policy parameter. PR #2212 was supposed to add only new 2018 policy parameter values. This problem was detected by rerunning the TAXSIM-27 validation test using the a17 sample and finding a test failure.

@martinholmer martinholmer changed the title Fix mistaken change in 2017 _EITC_ps_MarriedJ parameter in PR 2212 Fix mistaken change in 2017 _EITC_ps_MarriedJ parameter value made in PR 2212 Feb 22, 2019
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #2240 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2240   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          12      12           
  Lines        2945    2945           
======================================
  Hits         2945    2945

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54450fe...67d6fb6. Read the comment docs.

@martinholmer martinholmer merged commit 1234962 into PSLmodels:master Feb 22, 2019
@martinholmer martinholmer deleted the fix-2017-eitc-changes-in-pr2212 branch February 22, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant