Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename/remove a few policy params and archive some pre-TCJA reforms #2223

Merged
merged 8 commits into from
Feb 7, 2019
Merged

Rename/remove a few policy params and archive some pre-TCJA reforms #2223

merged 8 commits into from
Feb 7, 2019

Conversation

martinholmer
Copy link
Collaborator

This pull request resolves issue #2215.

Requesting review by @MattHJensen @codykallen @hdoupe @andersonfrailey @Peter-Metz

@codykallen
Copy link
Contributor

@martinholmer, these changes look good to me.

@andersonfrailey, it looks like there's some potential for merge conflicts between your PR #2222 and @martinholmer's PR #2223.

@martinholmer
Copy link
Collaborator Author

Reforms test fails on GitHub but passes on my computer. Will investigate this afternoon.

@martinholmer martinholmer changed the title Rename/remove a few policy params and some pre-TCJA reforms Rename/remove a few policy params and archive some pre-TCJA reforms Feb 6, 2019
@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #2223 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2223   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          12      12           
  Lines        2976    2981    +5     
======================================
+ Hits         2976    2981    +5
Impacted Files Coverage Δ
taxcalc/policy.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b336a8...50a890c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants