Switch Tax-Calculator code to being compatible with Python 3.6 only #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2058 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 16 16
Lines 3530 3515 -15
==========================================
- Hits 3529 3514 -15
Misses 1 1
Continue to review full report at Codecov.
|
martinholmer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next Tax-Calculator release will be 0.21.0 and the release notes for that version will include an API Change that says it is compatible with only Python 3.6.
Incompatibilities in the pandas library for Python 2.7 and Python 3.6 make it extremely difficult to make Tax-Calculator code and Cookbook recipes be compatible with both Python 2.7 and Python 3.6. We've been warning for many months that support for Python 2.7 was ending soon and that Tax-Calculator users should upgrade to Python 3.6 as soon as possible. The 0.20.3 release, which is compatible with Python 2.7, will remain available to users who have not upgraded to Python 3.6.