Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename classes as GrowFactors and GrowDiff #1996

Merged
merged 1 commit into from
May 11, 2018
Merged

Rename classes as GrowFactors and GrowDiff #1996

merged 1 commit into from
May 11, 2018

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented May 11, 2018

This pull request adopts the following PEP8 prescriptive naming convention for class names:

Class names should normally use the CapWords convention.

So, the Growfactors class has been renamed the GrowFactors class.
And the Growdiff class has been renamed the GrowDiff class.

Any Python scripts that use these two classes will need to be revised.

Also, the constructor dictionary argument in several classes derived from the ParametersBase class has been removed as was done for the Behavior class in pull request #1952.

@codecov-io
Copy link

codecov-io commented May 11, 2018

Codecov Report

Merging #1996 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1996   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          38      38           
  Lines        3782    3782           
======================================
  Hits         3782    3782
Impacted Files Coverage Δ
taxcalc/taxcalcio.py 100% <100%> (ø) ⬆️
taxcalc/consumption.py 100% <100%> (ø) ⬆️
taxcalc/behavior.py 100% <100%> (ø) ⬆️
taxcalc/growdiff.py 100% <100%> (ø) ⬆️
taxcalc/records.py 100% <100%> (ø) ⬆️
taxcalc/policy.py 100% <100%> (ø) ⬆️
taxcalc/growfactors.py 100% <100%> (ø) ⬆️
taxcalc/calculate.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6495291...3f76998. Read the comment docs.

@martinholmer martinholmer merged commit bd4e883 into PSLmodels:master May 11, 2018
@martinholmer martinholmer deleted the rename-param-classes branch May 12, 2018 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants