-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new 2011 PUF data in Tax-Calculator #1871
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1871 +/- ##
======================================
Coverage 100% 100%
======================================
Files 37 37
Lines 3211 3207 -4
======================================
- Hits 3211 3207 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged taxdata pull request 114 and merged taxdata pull request 150 --- both the work of @andersonfrailey --- together create a new
puf.csv
file and newpuf_weights.csv
andpuf_ratios.csv
files. Thegrowfactors.csv
file generated by taxdata 114 has been replaced in this pull request by a hand-editedgrowfactors.csv
file that has the same values as on the Tax-Calculator master branch for the years 2012+. (The taxdata version ofgrowfactors.csv
is conceptually the same but contains very small differences in the 2012+ growfactor values that generate many failures in unit tests that use CPS input data. The hand-edited version leaves all the CPS results unchanged.)Using these four new data files, all the CPS-related unit tests continue to pass and, as expected, the PUF-related unit tests produces slightly different results than were generated using the older 2009 PUF data.
This pull request has used the
puf.csv
file generated by taxdata pull request 150 that has the following characteristics: