Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for failing compatible_data tests #1839

Merged
merged 2 commits into from
Jan 23, 2018

Conversation

MattHJensen
Copy link
Contributor

Resolves #1823.

@MattHJensen
Copy link
Contributor Author

So far, resolves:

ERROR: _ID_Casualty_c not False for puf
ERROR: _ID_Casualty_frt not False for puf
ERROR: _ID_Miscellaneous_c not False for cps
ERROR: _ID_Miscellaneous_c not False for puf
ERROR: _ID_Miscellaneous_frt not False for cps
ERROR: _ID_Miscellaneous_frt not False for puf
ERROR: _ID_crt not False for cps
ERROR: _ID_crt not False for puf
ERROR: _ID_ps not False for cps
ERROR: _ID_ps not False for puf

Outstanding:

ERROR: _ID_BenefitSurtax_Switch not False for cps
ERROR: _ID_BenefitCap_Switch not False for cps

@codecov-io
Copy link

codecov-io commented Jan 21, 2018

Codecov Report

Merging #1839 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1839   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        3103    3103           
======================================
  Hits         3103    3103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc3d8d...a4ffc8a. Read the comment docs.

@MattHJensen
Copy link
Contributor Author

All resolved.

@MattHJensen MattHJensen removed the WIP label Jan 21, 2018
@martinholmer
Copy link
Collaborator

@MattHJensen, Thanks for fine tuning the compatible_data test.

@martinholmer martinholmer merged commit c0beac4 into PSLmodels:master Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants