Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and compatible_data fields for new policy parameters #1822

Merged
merged 2 commits into from
Jan 14, 2018
Merged

Add test and compatible_data fields for new policy parameters #1822

merged 2 commits into from
Jan 14, 2018

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Jan 13, 2018

This pull request adds a test to check that every policy parameter in the current_law_policy.json file has a compatible_data field, and it also adds a compatible_data field to each new parameter added in pull requests #1818 and #1819.

Because of the complexity of test_compatible_data, which was merged in pull request #1614, and the change in what is current-law policy, which happened in pull request #1803, there are still 7 (out of 45 pre_release tests) test failures in this pull request. The 11 parameters that failed test_compatible_data are as follows:

taxcalc$ py.test -n4 -m compatible_data 2>&1 | grep ERROR: | grep -v errmsg | sort
ERROR: _ID_BenefitSurtax_Switch not False for cps
ERROR: _ID_Casualty_c not False for puf
ERROR: _ID_Casualty_frt not False for puf
ERROR: _ID_Miscellaneous_c not False for cps
ERROR: _ID_Miscellaneous_c not False for puf
ERROR: _ID_Miscellaneous_frt not False for cps
ERROR: _ID_Miscellaneous_frt not False for puf
ERROR: _ID_crt not False for cps
ERROR: _ID_crt not False for puf
ERROR: _ID_ps not False for cps
ERROR: _ID_ps not False for puf

As you can see, all eleven failing parameters have to do with itemized deductions, the rules for which have changed substantially with the passage of TCJA.

@codecov-io
Copy link

codecov-io commented Jan 13, 2018

Codecov Report

Merging #1822 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1822   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        3098    3098           
======================================
  Hits         3098    3098

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3035d6...791d17d. Read the comment docs.

@martinholmer martinholmer merged commit e98bb95 into PSLmodels:master Jan 14, 2018
@martinholmer martinholmer deleted the testing-docs branch January 14, 2018 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants