Add test and compatible_data fields for new policy parameters #1822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a test to check that every policy parameter in the
current_law_policy.json
file has acompatible_data
field, and it also adds acompatible_data
field to each new parameter added in pull requests #1818 and #1819.Because of the complexity of
test_compatible_data
, which was merged in pull request #1614, and the change in what is current-law policy, which happened in pull request #1803, there are still 7 (out of 45 pre_release tests) test failures in this pull request. The 11 parameters that failedtest_compatible_data
are as follows:As you can see, all eleven failing parameters have to do with itemized deductions, the rules for which have changed substantially with the passage of TCJA.