Changes prompted by pre-merge discussion of pull request 1711 #1773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discussion of merged pull-request #1711 and of the unrelated pending pull request #1715 have revealed the need for a few documentation changes and simplification of the logic in
test_puf_var_stats.py
that generates variable means and correlation coefficients from thepuf.csv
file.With respect to the documentation changes in the Contributor Guide, see the discussion in #1711 and issue #1772. Any corrections in or suggestions about those changes in
contributor_guide.rst
are welcome.The
test_puf_var_stats.py
code has been changed to drop statistics on theagi_bin
variable and to reduce the numeric precision of the means (from the nearest one-tenth of a cent to the nearest dollar) and of the correlation coefficients (from three decimal places to two decimal places). These changes implement some of the ideas suggested in this comment in the discussion of pull request #1715.