Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes prompted by pre-merge discussion of pull request 1711 #1773

Merged
merged 8 commits into from
Dec 19, 2017
Merged

Changes prompted by pre-merge discussion of pull request 1711 #1773

merged 8 commits into from
Dec 19, 2017

Conversation

martinholmer
Copy link
Collaborator

The discussion of merged pull-request #1711 and of the unrelated pending pull request #1715 have revealed the need for a few documentation changes and simplification of the logic in test_puf_var_stats.py that generates variable means and correlation coefficients from the puf.csv file.

With respect to the documentation changes in the Contributor Guide, see the discussion in #1711 and issue #1772. Any corrections in or suggestions about those changes in contributor_guide.rst are welcome.

The test_puf_var_stats.py code has been changed to drop statistics on the agi_bin variable and to reduce the numeric precision of the means (from the nearest one-tenth of a cent to the nearest dollar) and of the correlation coefficients (from three decimal places to two decimal places). These changes implement some of the ideas suggested in this comment in the discussion of pull request #1715.

@codecov-io
Copy link

codecov-io commented Dec 18, 2017

Codecov Report

Merging #1773 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1773   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        3027    3027           
======================================
  Hits         3027    3027

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb40ba1...e3acb9d. Read the comment docs.

@martinholmer martinholmer merged commit 9bdba89 into PSLmodels:master Dec 19, 2017
@martinholmer martinholmer deleted the post-1711 branch December 19, 2017 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants