Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top-decile-detail logic in create_distribution_table utility function #1712

Merged
merged 4 commits into from
Nov 30, 2017
Merged

Fix top-decile-detail logic in create_distribution_table utility function #1712

merged 4 commits into from
Nov 30, 2017

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Nov 29, 2017

This pull request fixes a bug in create_distribution_table logic that generates information for subgroups of the top income decile. This bug was discovered while preparing a forthcoming pull request. The bug was caused by the initial design of the create_distribution_table utility function, which did work until top-decile-detail logic was first added. The solution was to redesign create_distribution_table logic to make it be more like the logic in the create_difference_table utility function. This bug fix leaves the basic ten-decile and All results unchanged.

This bug is in the current 0.13.2 release of Tax-Calculator, but it has limited impact because TaxBrain does not (yet?) show the top-decile subgroup statistics for the distribution table (or for the difference table, for that matter).

@codecov-io
Copy link

codecov-io commented Nov 29, 2017

Codecov Report

Merging #1712 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1712   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        2923    2927    +4     
======================================
+ Hits         2923    2927    +4
Impacted Files Coverage Δ
taxcalc/utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8f46f...10b9060. Read the comment docs.

@martinholmer martinholmer merged commit c9483ab into PSLmodels:master Nov 30, 2017
@martinholmer martinholmer deleted the fix-dist-table branch November 30, 2017 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants