Fix top-decile-detail logic in create_distribution_table utility function #1712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in
create_distribution_table
logic that generates information for subgroups of the top income decile. This bug was discovered while preparing a forthcoming pull request. The bug was caused by the initial design of thecreate_distribution_table
utility function, which did work until top-decile-detail logic was first added. The solution was to redesigncreate_distribution_table
logic to make it be more like the logic in thecreate_difference_table
utility function. This bug fix leaves the basic ten-decile and All results unchanged.This bug is in the current 0.13.2 release of Tax-Calculator, but it has limited impact because TaxBrain does not (yet?) show the top-decile subgroup statistics for the distribution table (or for the difference table, for that matter).