Add top-decile detail and new statistic to difference table #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1605 +/- ##
======================================
Coverage 100% 100%
======================================
Files 37 37
Lines 2767 2786 +19
======================================
+ Hits 2767 2786 +19
Continue to review full report at Codecov.
|
|
Looks great! Thanks @martinholmer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is built on pull request #1602, which added two new statistics (expanded income and after-tax expanded income) to the distribution table.
This pull request adds a new statistic (percentage change in after-tax expanded income) to the difference table and also adds top-decile details when the
create_difference_tablefunction is called withgroupby=weighted_deciles. These changes will be helpful in developing graphs like those discussed in issue #1592.This pull request also converts the data type of the percentage columns in the difference table from str to float.