Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize policy parameter suffix logic to handle non-default baseline Growdiff #1520

Merged
merged 2 commits into from
Aug 22, 2017
Merged

Generalize policy parameter suffix logic to handle non-default baseline Growdiff #1520

merged 2 commits into from
Aug 22, 2017

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Aug 21, 2017

This pull request generalizes the policy parameter suffix logic added in pull request #1505.
The old logic in #1505 works fine as long as the default price inflation and wage growth rates are being assumed (as they are when specifying a Tax-Calculator simulation using the TaxBrain GUI input page). However, when using the TaxBrain file upload page or when using Tax-Calculator on a local computer, the old #1505 logic was incorrect when using the growdiff_baseline dictionary to specify non-default price inflation or wage growth rates. This pull request fixes that problem. Other than this change, there are no changes to tax-calculating logic or tax results.

@MattHJensen @Amy-Xu @andersonfrailey @hdoupe @GoFroggyRun @codykallen

@codecov-io
Copy link

codecov-io commented Aug 21, 2017

Codecov Report

Merging #1520 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1520   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        2557    2565    +8     
======================================
+ Hits         2557    2565    +8
Impacted Files Coverage Δ
taxcalc/policy.py 100% <100%> (ø) ⬆️
taxcalc/growdiff.py 100% <100%> (ø) ⬆️
taxcalc/calculate.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e981d56...01e49ce. Read the comment docs.

@martinholmer martinholmer merged commit 2ce1335 into PSLmodels:master Aug 22, 2017
@martinholmer martinholmer deleted the generalize-suffix-logic branch August 22, 2017 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants