Generalize policy parameter suffix logic to handle non-default baseline Growdiff #1520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request generalizes the policy parameter suffix logic added in pull request #1505.
The old logic in #1505 works fine as long as the default price inflation and wage growth rates are being assumed (as they are when specifying a Tax-Calculator simulation using the TaxBrain GUI input page). However, when using the TaxBrain file upload page or when using Tax-Calculator on a local computer, the old #1505 logic was incorrect when using the
growdiff_baseline
dictionary to specify non-default price inflation or wage growth rates. This pull request fixes that problem. Other than this change, there are no changes to tax-calculating logic or tax results.@MattHJensen @Amy-Xu @andersonfrailey @hdoupe @GoFroggyRun @codykallen