Fix calculated-variable documentation and fix diagnostic table #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1328 +/- ##
==========================================
+ Coverage 99.65% 99.65% +<.01%
==========================================
Files 38 38
Lines 2896 2898 +2
==========================================
+ Hits 2886 2888 +2
Misses 10 10
Continue to review full report at Codecov.
|
Closed
|
@MattHJensen, commit 67c4b87 in pull request #1328 adds a fix for the dropq, and hence TaxBrain, distribution tables. Let me know if you think #1328 needs more work or if it can be merged as is. |
|
This looks great. +1 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request partially resolves issue #1325. Now the Tax-Calculator diagnostic table and TaxBrain distribution tables use
taxbc(instead ofc05200) for Regular Tax. Also, the Tax-Calculator diagnostic table adds an Other Taxes row so that now the table variables "add up" in the way most users would expect.What this pull request does not do is add an Other Taxes component to TaxBrain distribution tables, which means that the table columns will not "add up" the way most users would expect. As mentioned in issue #1325, the pros and cons of doing this should be discussed in #1325 or in a separate issue.
@MattHJensen @feenberg @Amy-Xu @andersonfrailey @GoFroggyRun @codykallen @zrisher
@PeterDSteinberg @brittainhard