Add --test option to tc CLI #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1306 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 38 38
Lines 2878 2878
=======================================
Hits 2868 2868
Misses 10 10Continue to review full report at Codecov.
|
|
This is nice!
On Apr 21, 2017, at 5:29 PM, Martin Holmer <[email protected]<mailto:[email protected]>> wrote:
This pull request add an installation test to the tc CLI.
No change in tax calculation logic or test results.
…________________________________
You can view, comment on, or merge this pull request online at:
#1306
Commit Summary
* Add --test option to tc CLI
File Changes
* M taxcalc/cli/tc.py<https://github.com/open-source-economics/Tax-Calculator/pull/1306/files#diff-0> (78)
* M taxcalc/records_variables.json<https://github.com/open-source-economics/Tax-Calculator/pull/1306/files#diff-1> (4)
Patch Links:
* https://github.com/open-source-economics/Tax-Calculator/pull/1306.patch
* https://github.com/open-source-economics/Tax-Calculator/pull/1306.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#1306>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AH6qJDzcTi1x0ESOr6RnnqonjTR8XE82ks5ryR-dgaJpZM4NEzxH>.
|
|
@MattHJensen said about the tc CLI installation test:
Just one of the things recommended by Karl Fogel in his book, |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add an installation test to the tc CLI.
NOTE that this enhancement was refined by two subsequent commits: d571c82 and 63595c2
No change in tax calculation logic or test results.