Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use error messages in TaxCalcIO instead of Python "raise Error" #1260

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Use error messages in TaxCalcIO instead of Python "raise Error" #1260

merged 1 commit into from
Mar 24, 2017

Conversation

martinholmer
Copy link
Collaborator

This pull request converts Python-style "raise Error" messages into simple error messages, more than one of which can be written to the screen via stderr. The reason for doing this is to further the goal of the CLI to Tax-Calculator, which is to make useful to those who know nothing about Python. The length "raise Error" traceback information is helpful only to Python programmers. Also, the "raise Error" approach to error handling stops program execute as soon the first error is found, while the approach adopted here can show several errors before stopping execution. This means users are likely to specify correct input more quickly than if errors are reported one at a time.

There is no change in substance in this pull request.

@codecov-io
Copy link

Codecov Report

Merging #1260 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
+ Coverage   99.67%   99.67%   +<.01%     
==========================================
  Files          38       38              
  Lines        2783     2805      +22     
==========================================
+ Hits         2774     2796      +22     
  Misses          9        9
Impacted Files Coverage Δ
taxcalc/taxcalcio.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2815c37...df35541. Read the comment docs.

@martinholmer martinholmer merged commit 30f05c8 into PSLmodels:master Mar 24, 2017
@martinholmer martinholmer deleted the tcio-error-msg branch March 24, 2017 14:09
@MattHJensen MattHJensen mentioned this pull request Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants