Add additional haircuts for deductions and credits #1247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional haircut options for a number of credits and deductions and fixes a minor error in the UBI function's docstring. There was nothing in the naming convention regarding what to name variables related to credits in this situation so I went with
CR
to start the haircut variables applied to credits. I'm happy to change that if there is consensus on a better option.The point is to allow a user to repeal credits and all above the line deductions. Here are the new haricuts and what they are applied to:
@MattHJensen @martinholmer