Read from JSON file using OrderedDict #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This guarantees that we preserve the order of key/value pairs as defined in the JSON files themselves.
Current coverage is 98.87% (diff: 66.66%)@@ master #1147 diff @@
==========================================
Files 38 38
Lines 3020 3021 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2986 2987 +1
Misses 34 34
Partials 0 0
|
|
@talumbau this is good. Not sure what the effect on the rest of the library will be, though. |
|
+1 here. |
|
@brittainhard @talumbau, I expect we'll be releasing a new tax-calculator today. Would you like this to be included? |
|
Yep. Merging. Thanks for the heads up! |
|
@talumbau, did you mean to merge? |
|
yes thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defined in the JSON files themselves.