Remove tmd data from Tax-Calculator repository

[martinholmer]

In keeping with the goals of open PR #2538, all data generated in the tax-microdata repository should be removed from the Tax-Calculator repository. As part of this effort, the static method called Records.tmd_constructor(...) will be revised to provide a convenient way to instantiate a Records object that uses the tmd.csv.gz data file, the tmd_weights.csv.gz file (or any sub-national area weights file), and the tmd_growfactors.csv file, all of which are available from the tax-microdata repository. This tmd_constructor will make it easy to use the tmd files in the Tax-Calculator Python API. The Tax-Calculator CLI tool, tc, will be revised so that tc can be used with these three external tmd files as long as they are all located in the same folder.

cc: @MattHJensen, @towashington, @jdebacker

[donboyd5]

I'm not sure if I'm reading this correctly. It seems to say that one impact of PR #2538 is that we will no longer be able to use the Tax-Calculator CLI tool for tmd files. As written, this seems to say that we cannot use tmd files with tc on local machines even when we are properly licensed to use the underlying PUF. While the python API is great, not being able to use the CLI tool seems like a big loss - for me, it's great for quick things when I don't want to fire up python, and just want to run a bash script. If I understand the impact correctly, I would much appreciate if someone involved in the PR could explain, whether the impact is intended, and if intended, what the rationale is. I've read the PR but not related history and I'm not sure I understand the impact or whether it's intended. (And if I misunderstand it, please set me straight - that would be good news.) Many thanks.

…

On Mon, Sep 23, 2024 at 7:18 PM Martin Holmer ***@***.***> wrote: In keeping with the goals of open PR #2538 <#2538>, all data generated in the tax-microdata <https://github.com/PSLmodels/tax-microdata-benchmarking> repository should be removed from the Tax-Calculator repository. As part of this effort, a static method called Records.tmd_constructor(...) will be added to provide a convenient way to instantiate a Records object that uses the tmd.csv.gz data file, the tmd_weights.csv.gz file, and the tmd_growfactors.csv file, all of which are available from the tax-microdata repository. This tmd_constructor will make it easy to use the tmd files in the Tax-Calculator Python API. But removing the tmd_weights.csv.gz and tmd_growfactors.csv files from the Tax-Calculator repository will mean that the tmd files will not be able to be used by the Tax-Calculator CLI tool, tc. cc: @MattHJensen <https://github.com/MattHJensen>, @towashington <https://github.com/towashington>, @jdebacker <https://github.com/jdebacker> — Reply to this email directly, view it on GitHub <#2808>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABR4JGGJJBALX4X4CPPSFLTZYCOV3AVCNFSM6AAAAABOXCGKXCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2DGOJSGAZDSOA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[martinholmer]

@donboyd5, I've edited the original comment in issue #2808 to say that the Tax-Calculator CLI tool, tc, will continue to be able to process TMD data files as long as all three of them are in the same folder.

[donboyd5]

Thanks! Sent from my phone; please excuse brevity and speech-to-text errors.

…

On Tue, Sep 24, 2024, 8:48 AM Martin Holmer ***@***.***> wrote: @donboyd5 <https://github.com/donboyd5>, I've edited the original comment in issue #2808 <#2808> to say that the Tax-Calculator CLI tool, tc, will continue to be able to process TMD data files as long as all three of them are in the same folder. — Reply to this email directly, view it on GitHub <#2808 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABR4JGH5H3IH3XR6IOTOC2TZYFNRTAVCNFSM6AAAAABOXCGKXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZRGE3TQMZXG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>