Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggest edit from jupyterbooks docs gives 404 #2456

Closed
MattHJensen opened this issue Aug 12, 2020 · 3 comments · Fixed by #2476
Closed

suggest edit from jupyterbooks docs gives 404 #2456

MattHJensen opened this issue Aug 12, 2020 · 3 comments · Fixed by #2476

Comments

@MattHJensen
Copy link
Contributor

Reported by @donboyd5 in #2454.
@MattHJensen MattHJensen mentioned this issue Aug 12, 2020
Closed
MaxGhenis added a commit to MaxGhenis/Tax-Calculator that referenced this issue Aug 22, 2020
@MaxGhenis
Change book_path to path_to_book
59cf68d 
Jupyter-Book looks to have changed the argument: https://jupyterbook.org/customize/config.html?highlight=issue#add-a-button-to-suggest-edits

Should fix PSLmodels#2456
@MaxGhenis MaxGhenis mentioned this issue Aug 22, 2020
Merged
@MattHJensen MattHJensen reopened this Aug 23, 2020
@MattHJensen
Copy link
Contributor Author

Just reopening to make sure I check back later to ensure the fix in #2476 propagates to the site.

@MaxGhenis
Copy link
Contributor

Just tested, it works now

@MattHJensen
Copy link
Contributor Author

Thanks Max. Works for me now too. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change book_path to path_to_book MaxGhenis/Tax-Calculator
2 participants
@MaxGhenis @MattHJensen