-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.8.5 #1364
Comments
Documentation of #1375 and #1376 has been moved from issue #1364 to the release history contained in the |
@martinholmer, thanks a lot for the tax-calculator/RELEASES.md file. Having that file is definitely valuable, and I see two paths for using it:
If we go with (1), I don’t think it is necessary to link to the PRs in RELEASES.md, those links will be available from the GH releases interface If we go with (2), I think it would also be helpful in RELEASES.md to include a link to the last commit in the release as well as the links to the PRs. The main advantage of (1) is that adding the links to PRs and last commit could be a minor inconvenience. The main advantage of (2) is that we don’t have duplicated information in RELEASES.md and the GH releases interface. |
@MattHJensen said:
Seems like (2) is the better option. So, I guess, you can create a release on GitHub without added the comment with description. Is that correct? I'd be happy to add in |
That is correct. I'll just include a link to RELEASES.md
That'd be great. Thanks! |
I hope to release 0.8.5 today, or as soon as we merge #1385. |
Thanks @andersonfrailey, @martinholmer, and @hdoupe for contributions to 0.8.5! |
After your pull requests are merged to master, please edit the 0.8.5 section of the release history and submit those edits as a pull request.
The last commit in 0.8.4 was 344e39f, which was the merge of #1363 on May 12, 2017.
The text was updated successfully, but these errors were encountered: