Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting #84

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix formatting #84

merged 1 commit into from
Jan 31, 2024

Conversation

talumbau
Copy link
Member

No description provided.

@talumbau
Copy link
Member Author

Hmm.. looks like the Codecov is failing for me:

[2024-01-31T17:01:05.977Z] ['verbose'] Passed token was 0 characters long

is the Codecov action known to currently work?
@jdebacker

@jdebacker
Copy link
Member

@talumbau Thanks for your work on this. I periodically have failures to upload to Codecov, but it's intermittent and I haven't identified a cause. I just restarted the job that failed upload and hope it will success this time.

@talumbau talumbau requested a review from jdebacker January 31, 2024 18:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9da4947) 73.76% compared to head (fe84c2f) 73.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   73.76%   73.76%           
=======================================
  Files          24       24           
  Lines        1616     1616           
=======================================
  Hits         1192     1192           
  Misses        424      424           
Flag Coverage Δ
unittests 73.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talumbau
Copy link
Member Author

OK. Looks like CodeCov is good to go then, correct? I'll merge this if you approve.

@jdebacker jdebacker merged commit c0802c6 into master Jan 31, 2024
11 of 12 checks passed
@jdebacker
Copy link
Member

Thanks for this TJ, just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants