Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated classifiers in setup.py #75

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

rickecon
Copy link
Member

This PR updates the classifiers in setup.py. This is important because the previous classifier of 'License :: OSI Approved :: CC0 1.0 Universal public domain dedication' was not valid and was breaking our publish_to_pypi.yml GitHub Action.

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Invalid value for classifiers. Error: Classifier 'License :: OSI       
         Approved :: CC0 1.0 Universal public domain dedication' is not a valid 
         classifier. 

This change should fix the issue. But the only way to test whether it works is to merge the PR.

@jdebacker. Will you please merge this PR as soon as all the tests (or 4 of the 6 tests) pass? Thanks.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e42207) 73.76% compared to head (8200d1f) 73.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   73.76%   73.76%           
=======================================
  Files          24       24           
  Lines        1616     1616           
=======================================
  Hits         1192     1192           
  Misses        424      424           
Flag Coverage Δ
unittests 73.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
setup.py 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickecon
Copy link
Member Author

@jdebacker. I think this PR is ready. The last two tests (Windows, Python 3.9 and 3.10) are just stalled at the test stage.

@rickecon rickecon merged commit bbdc01d into PSLmodels:master Oct 26, 2023
6 of 8 checks passed
@rickecon rickecon deleted the license branch October 26, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants