Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions and package deployment #74

Merged
merged 14 commits into from
Oct 26, 2023

Conversation

rickecon
Copy link
Member

This PR:

  • Updates README.md
  • Changes check_black.yml to check_format.yml
  • Updates other GH Action files: build_and_test.yml, docs_check.yml, and deploy_docs.yml
  • Updates publish_to_pypi.yml

cc: @jdebacker

@rickecon
Copy link
Member Author

@jdebacker. This PR is spinning out because we need to first merge in PR #73, which fixes the treatment of rho and surv_rate.

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d6aaba5) 73.76% compared to head (ed5c028) 73.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   73.76%   73.76%           
=======================================
  Files          24       24           
  Lines        1616     1616           
=======================================
  Hits         1192     1192           
  Misses        424      424           
Flag Coverage Δ
unittests 73.76% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cs-config/cs_config/functions.py 19.66% <0.00%> (ø)
setup.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rickecon
Copy link
Member Author

@jdebacker. I think this PR is ready for your review and subsequent merge if you think it is ready. It is still not passing the two Windows GH Action CI tests (those tests aren't even starting). This is similar to the previous PR and is an issue we need to resolve. But I think we can merge this in if you think it is ready.

@jdebacker
Copy link
Member

@rickecon These are some great additions here! Everything looks good to me and I'm merging. Looking forward to seeing ogusa on PyPI.

@jdebacker jdebacker merged commit 6e42207 into PSLmodels:master Oct 26, 2023
6 of 8 checks passed
@rickecon rickecon deleted the package branch October 26, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants