Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HSV functions to valid tax_func_type #941

Merged
merged 9 commits into from
Jun 18, 2024
Merged

Conversation

jdebacker
Copy link
Member

This PR updates the default_parameters.json file to add the HSV tax function type (HSV) to the list of valid entries for the tax_func_type parameter. This should have been added in PR #932, but was left out.

In addition, this PR updates the documentation files and some docstrings to reduce the number of warnings Jupyter-Book issues (partially addressing Issue #747).

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.92%. Comparing base (c16cf28) to head (f940b5a).
Report is 2 commits behind head on master.

Current head f940b5a differs from pull request most recent head 2e2a85f

Please upload reports for the commit 2e2a85f to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
- Coverage   71.93%   71.92%   -0.02%     
==========================================
  Files          19       19              
  Lines        4725     4723       -2     
==========================================
- Hits         3399     3397       -2     
  Misses       1326     1326              
Flag Coverage Δ
unittests 71.92% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ogcore/__init__.py 100.00% <100.00%> (ø)
ogcore/elliptical_u_est.py 100.00% <ø> (ø)
ogcore/utils.py 86.49% <ø> (ø)

@jdebacker jdebacker marked this pull request as ready for review June 17, 2024 19:00
@rickecon
Copy link
Member

@jdebacker. This is great. Thanks for fixing all those errors in the documentation. And the HSV addition in the documentation and in the default_parameters.json is nice. Merging.

@rickecon rickecon merged commit 38d7481 into PSLmodels:master Jun 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants