Fix to test_basic.py
#854
Merged
Fix to test_basic.py
#854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #854 +/- ##
==========================================
- Coverage 82.24% 82.18% -0.06%
==========================================
Files 18 18
Lines 3987 3992 +5
==========================================
+ Hits 3279 3281 +2
- Misses 708 711 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@rickecon This PR is ready for your review. |
rickecon
approved these changes
Feb 14, 2023
|
@jdebacker. I just reviewed and approved the changes. I am now rerunning the CI tests that failed. I wonder if the failures are coming from our tests taking more than the allotted compute time. We might have to choose whether we test on Python 3.9 or 3.10. |
|
@jdebacker. All tests have passed now. Looks great. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
test_basic.pyto specify ther_gov_shiftparameter as a list. This is necessary after changes from PR #852.Also fixes a comparison of the dimensions between the baseline solution and the reform parameters.