-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-publish to PyPI #795
Conversation
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
=======================================
Coverage 86.32% 86.32%
=======================================
Files 40 40
Lines 6318 6318
=======================================
Hits 5454 5454
Misses 864 864
Flags with carried forward coverage won't be shown. Click here to find out more. |
- name: Setup Python | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: 3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhilwoodruff and @jdebacker. Should we update the Python version in line 21 and line 50 from 3.7 to 3.9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rickecon I don't think it matters - that's just the version of Python used to build the package - not the version of Python the package is compatible with.
@nikhilwoodruff. I don't see anywhere this automatically updates the version number. I like your |
@rickecon I'd propose we leave the automatic version numbering for a separate PR. I could see cases where there is e.g., a small fix of a typo in the documentation - does that deserve a new version/package? With the |
Yeah, thanks both, I agree @jdebacker - plus, I just realised that the auto-changelog bumper needs another Github token setup, which complicates it slightly (right now, I think all version bumps on policyengine repos are all in my name). |
OK. Then I think this PR is ready. @jdebacker are you good? |
Thanks @nikhilwoodruff ! |
Following up on a call recently where there were some issues with pip installing, I thought I'd just file a PR here if it's useful. This is basically Jason's PR but with the extra step of an auto-publish action on the master branch. I think the only thing needed would be to make sure PSLmodels has an organisation secret called
PYPI
which is a token exported from thepypi.org
account.@jdebacker @rickecon @jpycroft FYI