Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-publish to PyPI #795

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Conversation

nikhilwoodruff
Copy link
Contributor

Following up on a call recently where there were some issues with pip installing, I thought I'd just file a PR here if it's useful. This is basically Jason's PR but with the extra step of an auto-publish action on the master branch. I think the only thing needed would be to make sure PSLmodels has an organisation secret called PYPI which is a token exported from the pypi.org account.

@jdebacker @rickecon @jpycroft FYI

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #795 (5854b88) into master (8ce4f4e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #795   +/-   ##
=======================================
  Coverage   86.32%   86.32%           
=======================================
  Files          40       40           
  Lines        6318     6318           
=======================================
  Hits         5454     5454           
  Misses        864      864           
Flag Coverage Δ
unittests 86.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: 3.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhilwoodruff and @jdebacker. Should we update the Python version in line 21 and line 50 from 3.7 to 3.9?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickecon I don't think it matters - that's just the version of Python used to build the package - not the version of Python the package is compatible with.

@rickecon
Copy link
Member

@nikhilwoodruff. I don't see anywhere this automatically updates the version number. I like your CHANGELOG.md approach in OpenFisca-UK. Can we add that to this PR, if @jdebacker and @rickecon create the appropriate CHANGELOG.md file and add it to your branch via PR?

@jdebacker
Copy link
Member

@rickecon I'd propose we leave the automatic version numbering for a separate PR. I could see cases where there is e.g., a small fix of a typo in the documentation - does that deserve a new version/package? With the skip_existing: true in the GH Action to publish, no new package will be uploaded to PyPI unless there is a version number change. So we might role with the auto publish as setup here for a bit and see how it works, then decide to adopt the auto version numbering. Does that sound like a plan?

cc @nikhilwoodruff

@nikhilwoodruff
Copy link
Contributor Author

Yeah, thanks both, I agree @jdebacker - plus, I just realised that the auto-changelog bumper needs another Github token setup, which complicates it slightly (right now, I think all version bumps on policyengine repos are all in my name).

@rickecon
Copy link
Member

OK. Then I think this PR is ready. @jdebacker are you good?

@jdebacker
Copy link
Member

Thanks @nikhilwoodruff !

@jdebacker jdebacker merged commit 4b24e2e into PSLmodels:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants