Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py #790

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Update setup.py #790

merged 1 commit into from
Mar 15, 2022

Conversation

jdebacker
Copy link
Member

This PR makes a few updates to setup.py necessary for publishing ogcore to PyPI:

  • Change wording for license description
  • Note that long description is being read from a md file
  • Update version number for consistency with repo

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #790 (e0ab107) into master (8ce4f4e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #790   +/-   ##
=======================================
  Coverage   86.32%   86.32%           
=======================================
  Files          40       40           
  Lines        6318     6318           
=======================================
  Hits         5454     5454           
  Misses        864      864           
Flag Coverage Δ
unittests 86.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rickecon
Copy link
Member

rickecon commented Mar 8, 2022

@jdebacker. Is this ready to merge once all the checks pass? It looks good to me.

@jdebacker
Copy link
Member Author

@rickecon I still have one outstanding issue, though I'm not sure it can be resolved. Here's my comment from Element:

Created a test package of OG-Core: https://test.pypi.org/project/ogcore/0.8.0/ but it doesn't seem to install the mkl dependency. I needed to do that separately then package installed ok. Anyone else having this issue? Thoughts on why?

@rickecon
Copy link
Member

rickecon commented Mar 10, 2022

@jdebacker. Two comments

  1. Potentially it might be helpful to list Python 3.10 as a programming language after line 42 in setup.py. There might be some issue where the packages needed require 3.10 for all of them to work. (This is likely not the case, but we should have this line anyway.)
'Programming Language :: Python :: 3.10',
  1. Despite mkl being on PyPI, a lot of the online forums suggest downloading through conda. (see here and here)

But this really doesn't make any sense. I think the best way to do this is to use pypi.org so the package can be pip installed. It would be really nice to get this to work.

@jdebacker jdebacker merged commit 6fa5aff into PSLmodels:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants