Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning from using deprecated method with size argument #387

Merged
merged 3 commits into from
Apr 21, 2024
Merged

Fix warning from using deprecated method with size argument #387

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bc7890
Fix warning from using deprecated method with size argument
kcreekdev Apr 13, 2024
494f346
Fix circle call in range_plot method
kcreekdev Apr 13, 2024
ac525cd
One more rename to scatter
kcreekdev Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ccc/calculator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1379,7 +1379,7 @@ def range_plot(
source=base_source,
)
# Add circles for means
p.circle(
p.scatter(
"positions",
"means",
size=12,
Expand All @@ -1388,15 +1388,15 @@ def range_plot(
legend_label="Baseline",
)
# Add circles for maxes and mins
p.circle(
p.scatter(
"positions",
"mins",
size=12,
color=BLUE,
source=base_source,
legend_label="Baseline",
)
p.circle(
p.scatter(
"positions",
"maxes",
size=12,
Expand All @@ -1416,7 +1416,7 @@ def range_plot(
source=reform_source,
)
# Add circles for means
p.circle(
p.scatter(
"positions",
"means",
size=12,
Expand All @@ -1425,15 +1425,15 @@ def range_plot(
legend_label="Reform",
)
# Add circles for maxes and mins
p.circle(
p.scatter(
"positions",
"mins",
size=12,
color=RED,
source=reform_source,
legend_label="Reform",
)
p.circle(
p.scatter(
"positions",
"maxes",
size=12,
Expand Down Expand Up @@ -1744,7 +1744,7 @@ def bubble_widget(
p.outline_line_alpha = 1
p.outline_line_color = "black"

p.circle(
p.scatter(
x="rate",
y="short_category",
color=BLUE,
Expand Down Expand Up @@ -1808,7 +1808,7 @@ def bubble_widget(
p2.xaxis.major_tick_line_width = 3
p2.xaxis.minor_tick_line_color = "orange"

p2.circle(
p2.scatter(
x="rate",
y="short_category",
color=RED,
Expand Down Expand Up @@ -2120,7 +2120,7 @@ def asset_bubble(
p.outline_line_alpha = 1
p.outline_line_color = "black"

p.circle(
p.scatter(
x="baseline",
y="short_category",
color=BLUE,
Expand Down Expand Up @@ -2201,7 +2201,7 @@ def asset_bubble(
p2.xaxis.major_tick_line_width = 3
p2.xaxis.minor_tick_line_color = "orange"

p2.circle(
p2.scatter(
x="baseline",
y="short_category",
color=RED,
Expand Down
Loading