Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load notices into a List to allow programmatic modifications #21

Closed
adlerjohn opened this issue Feb 26, 2014 · 1 comment
Closed

Load notices into a List to allow programmatic modifications #21

adlerjohn opened this issue Feb 26, 2014 · 1 comment

Comments

@adlerjohn
Copy link

The Google Maps Android v2, for example, requires a license to be displayed that can only be correctly fetched programmatically.

Current behaviour for multiple licenses
Notices have to be stored statically in an XML file. They are loaded directly to a LicensesDialog or LicensesDialogFragment with no chance for the developer to modify them/append more licenses.

Suggested behaviour for multiple licenses
Allow the developer to load notices from an XML file into an ordered List of Notices (I think this is already supported to a certain extent through NoticesXmlParser, but not with an easy way to pass resource IDs). Then set a List<Notice> as one of the parameters to the constructors of LicensesDialog and LicensesDialogFragment.

@hameno
Copy link
Member

hameno commented Feb 27, 2014

👍

hameno added a commit that referenced this issue Feb 27, 2014
@hameno hameno closed this as completed Apr 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants