Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust version compatibility #37

Closed
eitsupi opened this issue Jan 18, 2023 · 4 comments · Fixed by #38, #39 or #42
Closed

Rust version compatibility #37

eitsupi opened this issue Jan 18, 2023 · 4 comments · Fixed by #38, #39 or #42
Labels
bug Something isn't working
Milestone

Comments

@eitsupi
Copy link
Member

eitsupi commented Jan 18, 2023

Both R-hub builder and R-universe builder (ubuntu:jammy) failed installation with the following error after using prql-compiler 0.4.0.
https://github.com/r-universe/eitsupi/actions/runs/3941624440/jobs/6752975644#step:3:802

  error[E0658]: `let...else` statements are unstable
     --> /tmp/RtmpnXSnJF/R.INSTALLfa93bec8912/prqlr/src/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/prql-compiler-0.4.0/src/semantic/lowering.rs:453:13
      |
  453 | /             let pl::ExprKind::All { except, .. } = expr.kind else {
  454 | |                 // base case
  455 | |                 r.push(self.declare_as_column(expr, is_aggregation)?);
  456 | |                 continue;
  457 | |             };
      | |______________^
      |
      = note: see issue #87335 <https://github.com/rust-lang/rust/issues/87335> for more information
@eitsupi eitsupi added the bug Something isn't working label Jan 18, 2023
@eitsupi eitsupi added this to the 0.1.0 milestone Jan 18, 2023
@eitsupi
Copy link
Member Author

eitsupi commented Jan 18, 2023

#38 does not seem enough for R-universe.

   	cargo build --lib --release --manifest-path=./rust/Cargo.toml --target-dir ./rust/target
      Updating git repository `https://github.com/extendr/extendr`
      Updating crates.io index
      Updating git repository `https://github.com/PRQL/prql`
  error: failed to get `prql-compiler` as a dependency of package `prqlr v0.1.0 (/tmp/RtmpilNWCq/Rbuild5ef55c3be2a/prqlr/src/rust)`
  
  Caused by:
    failed to load source for dependency `prql-compiler`
  
  Caused by:
    Unable to update https://github.com/PRQL/prql?rev=1b4217c01c590c51a3e80c8a11b28f78f109a110#1b4217c0
  
  Caused by:
    object not found - no match for id (1b4217c01c590c51a3e80c8a11b28f78f109a110); class=Odb (9); code=NotFound (-3)
  make: *** [Makevars:16: rust/target/release/libprqlr.a] Error 101
  ERROR: compilation failed for package ‘prqlr’

@eitsupi
Copy link
Member Author

eitsupi commented Jan 18, 2023

Curiously, the following build (ubuntu:jammy based rocker/r-ver) succeeds.

-> The installation was failing, but it just wasn't getting build errors......

docker build -t prqlr-test -<<EOF
FROM rocker/r-ver
RUN apt-get update && apt-get install -y --no-install-recommends cargo git
RUN R -s -e 'install.packages("remotes")'
RUN R -q -e 'remotes::install_git("https://github.com/eitsupi/prqlr.git", ref = "9131d1cc5e227f368e57015aa29819c34db15a19")'
EOF

@eitsupi
Copy link
Member Author

eitsupi commented Jan 18, 2023

The cause was the use of the original URL even though it is ref of fork commit, and the use of the version.workspace.

@eitsupi
Copy link
Member Author

eitsupi commented Jan 19, 2023

Reopened by #40...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment