Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make version extraction more reliable #3166

Merged
merged 3 commits into from
Jul 29, 2023
Merged

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Jul 29, 2023

#3122 (comment)

There is no need to remove spaces or quotation marks because cargo metadata correctly parses the TOML and extracts the version number.

@eitsupi
Copy link
Member Author

eitsupi commented Jul 29, 2023

It does not seem working on Windows

  ./.github/set_version.sh
  shell: C:\Program Files\Git\bin\bash.EXE --noprofile --norc -e -o pipefail {0}
  env:
    CARGO_TERM_COLOR: always
    CLICOLOR_FORCE: 1
    RUSTFLAGS: -C debuginfo=0
./.github/set_version.sh: line 5: yq: command not found

I thought yq was available on GitHub Actions, but it doesn't seem to be included on Windows at this time. (actions/runner-images#7443)
https://github.com/actions/runner-images/blob/win22/20230724.1/images/win/Windows2022-Readme.md

@eitsupi eitsupi closed this Jul 29, 2023
@eitsupi eitsupi deleted the ci-yq branch July 29, 2023 06:43
@max-sixty
Copy link
Member

FYI cargo metadata & jq is probably the "optimizer" (not necessarily good!) approach...

@eitsupi eitsupi restored the ci-yq branch July 29, 2023 08:43
@eitsupi eitsupi reopened this Jul 29, 2023
@eitsupi eitsupi changed the title ci: use yq to extract version number from the TOML file ci: use cargo metadata and jq to extract version number from the TOML file Jul 29, 2023
@eitsupi
Copy link
Member Author

eitsupi commented Jul 29, 2023

FYI cargo metadata & jq is probably the "optimizer" (not necessarily good!) approach...

Good idea! Thanks.

@not-my-profile not-my-profile changed the title ci: use cargo metadata and jq to extract version number from the TOML file ci: make version extraction more reliable Jul 29, 2023
Copy link
Member

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@max-sixty max-sixty merged commit 2a9581c into PRQL:main Jul 29, 2023
@eitsupi eitsupi deleted the ci-yq branch July 29, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants