build: Compile prql-js
for wasm only
#3115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to look at #3098, I tried to look at what was causing the builds the second time around.
Here's a
fish
script (easy to adjust forbash
):Then there's two lines in
build.log
for the same dependency, one from the first; one from the second:These have different features — only one has
alloc
. And then running:...helps find the thing that's generating the request for the
alloc
feature — in this casewasm-bindgen
.This seems like a very labor-intensive way of trying to unify dependencies between each crate & the workspace. But I'm including the first fix, which is to not compile
wasm-bindgen
for non-wasm targets.So:
cargo build -p prqlc
isn't really cached aftercargo build
#3098