Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create profile pages #976

Closed
thewilkybarkid opened this issue May 30, 2023 · 0 comments
Closed

Create profile pages #976

thewilkybarkid opened this issue May 30, 2023 · 0 comments

Comments

@thewilkybarkid
Copy link
Member

No description provided.

thewilkybarkid added a commit that referenced this issue May 30, 2023
@thewilkybarkid
Sort by publication date on Zenodo
bd8e257 
It's a bit hidden in the Zenodo docs, but it's possible to sort by publication date rather than creation date.

Refs #976, https://help.zenodo.org/guides/search/
thewilkybarkid added a commit that referenced this issue May 30, 2023
@thewilkybarkid
Add a hardcoded profile page with a list of PREreviews
df362af 
Refs #976
thewilkybarkid added a commit that referenced this issue May 30, 2023
@thewilkybarkid
Push out hard-coded data from the template
3dc3e57 
Refs #976
thewilkybarkid added a commit that referenced this issue May 30, 2023
@thewilkybarkid
Push out hard-coded name from the template
7ee7d8e 
Refs #976
thewilkybarkid added a commit that referenced this issue May 30, 2023
@thewilkybarkid
Push up hard-coded data
f69c192 
Refs #976
thewilkybarkid added a commit that referenced this issue May 30, 2023
@thewilkybarkid
Allow the profile page to fail
4953776 
This change is a prerequisite to removing the hard-coded data.

Refs #976
thewilkybarkid added a commit that referenced this issue May 30, 2023
@thewilkybarkid
Push up hard-coded data
9e4297a 
Refs #976
thewilkybarkid added a commit that referenced this issue May 30, 2023
@thewilkybarkid
Fix test file
0b0c8d3 
Refs #976
thewilkybarkid added a commit that referenced this issue May 30, 2023
@thewilkybarkid
Pass the ORCID iD to the data fetchers
e10e53b 
This change is a prerequisite to removing the ORCID iD hard coding from the route. Note that it doesn't yet load remote data.

Refs #976
thewilkybarkid added a commit that referenced this issue May 30, 2023
@thewilkybarkid
Remove hard-coding from the route
5c59c78 
Refs #976
erkannt added a commit that referenced this issue May 31, 2023
@erkannt
Add a stub request to the ORCID API
40c7d3c 
Refs: #976
thewilkybarkid added a commit that referenced this issue May 31, 2023
@thewilkybarkid
Fix integration test
b11a783 
Refs #976, 40c7d3c
thewilkybarkid added a commit that referenced this issue May 31, 2023
@thewilkybarkid
Filter away non-200 responses
7f65c76 
Refs #976
erkannt added a commit that referenced this issue May 31, 2023
@erkannt
Fix test
28c5bb0 
The fetch-mock library turn 0 status codes into 200s.

Refs: #976, 7f65c76
erkannt added a commit that referenced this issue May 31, 2023
@erkannt
Read the name from the ORCID response
5b64ba4 
This assumes the response has both a given and a family name and that
the given name should precede the family name.

Refs: #976
thewilkybarkid added a commit that referenced this issue May 31, 2023
@thewilkybarkid
Create observability for when we're unable to load a name from the OR…
49ea0a6 
…CID API

Refs #976
erkannt added a commit that referenced this issue May 31, 2023
@erkannt
Remove accidental change
28984bb 
Refs: #976, 49ea0a6
erkannt added a commit that referenced this issue May 31, 2023
@erkannt
Get author's prereviews from Zenodo
ece4798 
Refs: #976
thewilkybarkid added a commit that referenced this issue May 31, 2023
@thewilkybarkid
Expand tests
f31ef07 
Refs #976, ece4798
thewilkybarkid added a commit that referenced this issue May 31, 2023
@thewilkybarkid
Improve performance of the PREreviews list
dbdf5ea 
Refs #976
thewilkybarkid added a commit that referenced this issue May 31, 2023
@thewilkybarkid
Treat an empty list as not found
0bab443 
Refs #976
thewilkybarkid added a commit that referenced this issue May 31, 2023
@thewilkybarkid
Load profiles for any ORCID iD
416c202 
Refs #976
thewilkybarkid added a commit that referenced this issue May 31, 2023
@thewilkybarkid
Fix test
90c9a97 
Refs #976, 416c202
thewilkybarkid added a commit that referenced this issue May 31, 2023
@thewilkybarkid
Fix formatting
b47ba94 
Refs #976, 416c202
thewilkybarkid added a commit that referenced this issue May 31, 2023
@thewilkybarkid
Add a link to the ORCID record
2f5cf72 
Refs #976
thewilkybarkid added a commit that referenced this issue May 31, 2023
@thewilkybarkid
Fix padding
ad11e08 
Refs #976, 2f5cf72
thewilkybarkid added a commit that referenced this issue Jun 1, 2023
@thewilkybarkid
Try and speed up the integration tests by just running the Playwright…
ebc5045 
… step inside the Playwright container

I've tried running the whole job in the Playwright container previously but had trouble enabling Git LFS. I've just discovered that you can run an individual step inside a container. This change allows us to build the app outside of Docker (and so can benefit from things like npm caching, multistage builds etc.). This change worked locally with Act.

Refs #976, 7d29c5f, microsoft/playwright#23388 (comment), https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-a-docker-public-registry-action
thewilkybarkid added a commit that referenced this issue Jun 1, 2023
@thewilkybarkid
Try and prevent GitHub Actions from stopping Firefox running
8f7b96e 
Refs #976, ebc5045, microsoft/playwright#6500
thewilkybarkid added a commit that referenced this issue Jun 1, 2023
@thewilkybarkid
Revert "Try and speed up the integration tests by just running the Pl…
b078d69 
…aywright step inside the Playwright container"

Refs #976, microsoft/playwright#23388 (comment), reverts  ebc5045, 8f7b96e
thewilkybarkid added a commit that referenced this issue Jun 1, 2023
@thewilkybarkid
Show profile pages where there are no PREreviews
1b4b906 
Refs #976
thewilkybarkid added a commit that referenced this issue Jun 1, 2023
@thewilkybarkid
Make use of the user arbitrary
beafcca 
Refs #976
thewilkybarkid added a commit that referenced this issue Jun 1, 2023
@thewilkybarkid
Restrict pseudonyms with a dedicated type
f89345c 
Refs #976
thewilkybarkid added a commit that referenced this issue Jun 1, 2023
@thewilkybarkid
Allow loading PREreviews for a pseudonym
0aea7d9 
Refs #976
thewilkybarkid added a commit that referenced this issue Jun 1, 2023
@thewilkybarkid
Add a profile page for pseudonyms
6820a10 
Refs #976
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Retry speeding up the integration tests by just running the Playwrigh…
5e2bf81 
…t step inside the Playwright container

Refs #976, microsoft/playwright#23388 (comment), reverts b078d69
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Reuse existing build
dc04b4f 
Refs #976, 5e2bf81
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Speed up the integration tests
614f97c 
This change runs more shards, which are now noticeably quicker to start.

Refs #976, 5e2bf81, dc04b4f
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Speed up the tests
460ad81 
Due to the property tests, Jest takes a little while to run. This change splits it into multiple jobs, similar to the integration tests.

Refs #976, https://jestjs.io/docs/next/cli#--shard
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Avoid a union of strings with a dedicated type
dd1b4a8 
Refs #976
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Avoid having separate routes
a1f3025 
Refs #976, dd1b4a8
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Avoid having separate pages
19ef618 
Refs #976, a1f3025
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Redirect old profile page URLs
db8515f 
Refs #976
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Link to profile pages rather than to ORCID records
6c4cec8 
Refs #976, https://prereview.slack.com/archives/CR6B5804W/p1685555169275819
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Link pseudonyms to their profile page
9744d79 
Refs #976, 6c4cec8
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Simplify
057a986 
Refs #976, 5b64ba4
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Remove redundant flow
fee52b6 
Refs #976, 416c202
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Extract a named function
28af32c 
Refs #976
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Test the requested URL
d1eadeb 
Refs #976
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Try and improve the performance of getting a name from ORCID
ba069a5 
Unfortunately, the ORCID API returns strict caching headers that prevent our local cache from working. This commit will be helpful if they decide to relax it.

Refs #976
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Add a page with basic details about the logged-in user
88fdb28 
Refs #976
thewilkybarkid added a commit that referenced this issue Jun 2, 2023
@thewilkybarkid
Add a link to the user's details page
e63688b 
Refs #976, 88fdb28
thewilkybarkid added a commit that referenced this issue Jun 5, 2023
@thewilkybarkid
Add name
da92f7a 
Refs #976
thewilkybarkid added a commit that referenced this issue Jun 15, 2023
@thewilkybarkid
Correct a mocked URL
047d979 
Refs #976, db8515f
thewilkybarkid added a commit that referenced this issue Jun 15, 2023
@thewilkybarkid
Ensure that mocked requests are matched
ceea33f 
This change uses fetch-mock's 'done' inspection to ensure that it matches the requests as expected to avoid tests passing for the wrong reason (i.e. we didn't mock a response).

I think I've found a bug in fetch-mock where it doesn't recognise that it matched a request when testing a query string independently of the URL. It works as expected when only partially matching the URL.

Refs #976, 047d979, https://www.wheresrhys.co.uk/fetch-mock/#api-inspectiondone, wheresrhys/fetch-mock#657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thewilkybarkid