Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS2] Use relative names for kiss topics #414

Open
fdila opened this issue Dec 10, 2024 · 0 comments
Open

[ROS2] Use relative names for kiss topics #414

fdila opened this issue Dec 10, 2024 · 0 comments

Comments

@fdila
Copy link

fdila commented Dec 10, 2024

Very minor issue: since the various topics that kiss_icp uses begin with "/" they are absolute, and when running kiss_icp with a specified namespace they don't get remapped.

Allowing namespaces would just be a matter of removing the "/" from the beginning of the name topics here:

odom_publisher_ = create_publisher<nav_msgs::msg::Odometry>("/kiss/odometry", qos);
if (publish_debug_clouds_) {
frame_publisher_ = create_publisher<sensor_msgs::msg::PointCloud2>("/kiss/frame", qos);
kpoints_publisher_ =
create_publisher<sensor_msgs::msg::PointCloud2>("/kiss/keypoints", qos);
map_publisher_ = create_publisher<sensor_msgs::msg::PointCloud2>("/kiss/local_map", qos);

This modification would be beneficial on a multi-robot setup, since using namespaces is pretty much required to run multiple instances of the same node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant