Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework folder structure for visualizer #31

Merged
merged 18 commits into from
Aug 21, 2024
Merged

Rework folder structure for visualizer #31

merged 18 commits into from
Aug 21, 2024

Conversation

saurabh1002
Copy link
Collaborator

@saurabh1002 saurabh1002 commented Aug 16, 2024

The previous visualizer.py file was too big and unreadable, so might lead to problems later when making changes if necessary. So, in this PR, I do the following:

  1. Create a subfolder for the visualization and do everything there
  2. Split the existing visualizer into its core components, such as the RegistrationVisualizer and ClosuresVisualizer and use them through the main Visualizer class, and wrap main API functions around this new pattern.
  3. Create a common dataclass LocalMapData containing the individual local maps, density maps and other params relating to them, that can be shared across different visualizer components, without having to use up too much space.
  4. Lastly, I added an important visualization feature to loop over all the local maps and corresponding density maps generated upto any given frame in the dataset. This is very useful for debugging the performance of MapClosures on challenging datasets. This is the LocalMapVisualizer.
  5. Each of these individual classes are defined in separate python files for better maintainence.

@saurabh1002 saurabh1002 requested a review from l00p3 August 16, 2024 12:15
@saurabh1002 saurabh1002 changed the title minor updates to data interface for the visualizer Rework folder structure for visualizer Aug 16, 2024
@l00p3
Copy link
Contributor

l00p3 commented Aug 16, 2024

Good boy.

@tizianoGuadagnino
Copy link
Collaborator

@saurabh1002 can you please add a minimal description? I have no clue what is going on here

@saurabh1002 saurabh1002 added enhancement New feature or request python labels Aug 20, 2024
@saurabh1002 saurabh1002 requested a review from l00p3 August 20, 2024 07:33
@saurabh1002 saurabh1002 merged commit 4ae8cf9 into main Aug 21, 2024
@saurabh1002 saurabh1002 deleted the new_visualizer branch August 21, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants