-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework folder structure for visualizer #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabh1002
changed the title
minor updates to data interface for the visualizer
Rework folder structure for visualizer
Aug 16, 2024
Good boy. |
l00p3
approved these changes
Aug 16, 2024
@saurabh1002 can you please add a minimal description? I have no clue what is going on here |
tizianoGuadagnino
approved these changes
Aug 20, 2024
l00p3
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
visualizer.py
file was too big and unreadable, so might lead to problems later when making changes if necessary. So, in this PR, I do the following:RegistrationVisualizer
andClosuresVisualizer
and use them through the mainVisualizer
class, and wrap main API functions around this new pattern.LocalMapData
containing the individual local maps, density maps and other params relating to them, that can be shared across different visualizer components, without having to use up too much space.LocalMapVisualizer
.